Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove products from product collection type in generated references #7812

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

shahednasser
Copy link
Member

Note: This change isn't necessary for v2.

The ProductCollection schema and entity both have a products property. However, no API routes accept to expand this relation.

This removes the products property from the generated references in the documentation. Once this PR is merged, I'll trigger the action to re-generate the references.

@shahednasser shahednasser requested review from a team as code owners June 24, 2024 09:33
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 9:34am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jun 24, 2024 9:34am
docs-ui ⬜️ Ignored (Inspect) Jun 24, 2024 9:34am
medusa-docs ⬜️ Ignored (Inspect) Jun 24, 2024 9:34am

Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: 4db1dba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shahednasser shahednasser merged commit 93e5078 into v1.x Jun 25, 2024
30 checks passed
@shahednasser shahednasser deleted the fix/prod-collection-expand branch June 25, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants