Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows,types): cancel order changes workflow #8035

Merged
merged 15 commits into from
Jul 9, 2024
Merged

feat(core-flows,types): cancel order changes workflow #8035

merged 15 commits into from
Jul 9, 2024
+608 −9

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jul 9, 2024

what:

  • adds cancel order changes workflow

riqwan added 8 commits July 9, 2024 11:24
@riqwan
chore: added order change create workflow

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
4afb7c1
@riqwan
Merge branch 'develop' into feat/order-changes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
a27f8a0
@riqwan
chore: fix comments
1240862
@riqwan
chore: remove redundant service + add validation on module service
dd62741
@riqwan
Merge branch 'develop' into feat/order-changes
af43d2e
@riqwan
chore: ignore fixtures folder
edf110a
@riqwan
Merge branch 'develop' into feat/order-changes
65a3e3f
@riqwan
chore: cancel order changes workflow
ac28c4e
@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 1:56pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 9, 2024 1:56pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 1:56pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 1:56pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 1:56pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 1:56pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 1:56pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 65527b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review July 9, 2024 12:10
@riqwan riqwan requested a review from a team as a code owner July 9, 2024 12:10
@riqwan riqwan requested review from sradevski, adrien2p, olivermrbl and carlos-r-l-rodrigues and removed request for a team July 9, 2024 12:10
Base automatically changed from feat/order-changes to develop July 9, 2024 12:13
@riqwan riqwan requested a review from fPolic July 9, 2024 12:13
carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Jul 9, 2024
View reviewed changes
packages/core/core-flows/src/order/steps/cancel-order-change.ts Outdated
status: dataBeforeUpdate.status,
canceled_at: null,
canceled_by: null,
metadata: dataBeforeUpdate.metadata,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the metadata here?
that probably won't be touched if we only update the other fields no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, made it dynamic based on inputs

@kodiakhq kodiakhq bot merged commit 566bbd5 into develop Jul 9, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/order-changes-cancel branch July 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski

@adrien2p adrien2p

@olivermrbl olivermrbl

@fPolic fPolic

@carlos-r-l-rodrigues carlos-r-l-rodrigues

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riqwan @carlos-r-l-rodrigues