- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): JSON view #8038
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
e.stopPropagation() | ||
setCopied(true) | ||
|
||
if (typeof value === "string") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't really need this check, JSON.stringify("string", null, 2)
will just give you "string" anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seb wants strings to be copied without quotation marks, and as you say it gives you "string" 😄
@olivermrbl Can you take a look at this on behalf of the UI team, this PR also includes the latest styles from Figma, that I need for other PRs so would be great to get it merged 😄 |
What
Note
@radix-ui/react-scroll-area
.RESOLVES CORE-2499