Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): JSON view #8038

Merged
merged 4 commits into from
Jul 9, 2024
Merged

fix(dashboard): JSON view #8038

merged 4 commits into from
Jul 9, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Jul 9, 2024

What

  • Updates the look of the JSON view

Note

  • This component, plus many others need a different styling of the scrollbar and thumb. Will follow up with that in a separate PR, properly introducing some component based on @radix-ui/react-scroll-area.
image

RESOLVES CORE-2499

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 2:21pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 9, 2024 2:21pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 2:21pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 2:21pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 2:21pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 2:21pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 2:21pm

Copy link

changeset-bot bot commented Jul 9, 2024

⚠️ No Changeset found

Latest commit: 3aa725d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

e.stopPropagation()
setCopied(true)

if (typeof value === "string") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't really need this check, JSON.stringify("string", null, 2) will just give you "string" anyway

Copy link
Contributor Author

@kasperkristensen kasperkristensen Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seb wants strings to be copied without quotation marks, and as you say it gives you "string" 😄

@kasperkristensen
Copy link
Contributor Author

@olivermrbl Can you take a look at this on behalf of the UI team, this PR also includes the latest styles from Figma, that I need for other PRs so would be great to get it merged 😄

@kasperkristensen kasperkristensen merged commit 4736d9e into develop Jul 9, 2024
23 checks passed
@kasperkristensen kasperkristensen deleted the feat/updated-json-view branch July 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants