Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Add safe zone around link Table rows #8058

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Jul 10, 2024

What

  • After adding Table rows as links there was an issue where clicking close to a Checkbox in a row would click the link. This PR adds a safe zone around the Checkboxes, so you don't end up navigating when trying to select a row.

image

RESOLVES CORE-2566

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:23am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 10, 2024 10:23am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 10:23am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 10:23am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 10:23am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 10:23am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 10:23am

Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: c42dc54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl
Copy link
Contributor

olivermrbl commented Jul 10, 2024

@kasperkristensen, can you include a fix for this one in this PR as well.

@kasperkristensen
Copy link
Contributor Author

kasperkristensen commented Jul 10, 2024

@kasperkristensen, can you include a fix for this one in this PR as well.

Already part of the PR 👍

@olivermrbl
Copy link
Contributor

olivermrbl commented Jul 10, 2024

Already part of the PR 👍

Ah my bad. Just read the description and thought it was only fixing the issue with a checkbox safe zone

@kodiakhq kodiakhq bot merged commit 04ec8e7 into develop Jul 10, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/clickable-rows branch July 10, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants