Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): product create input focus #8095

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(dashboard): product create input focus #8095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...s/product-create/components/product-create-variants-form/product-create-variants-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ export const ProductCreateVariantsForm = ({

const { price_preferences: pricePreferences } = usePricePreferences({})

const currencyCodes = useMemo(
() => store?.supported_currencies?.map((c) => c.currency_code) || [],
[store]
)

const variants = useWatch({
control: form.control,
name: "variants",
Expand All @@ -38,9 +43,12 @@ export const ProductCreateVariantsForm = ({
defaultValue: [],
})

/**
* NOTE: anything that goes to the datagrid component needs to be memoised otherwise DataGrid will rerender and inputs will loose focus
*/
const columns = useColumns({
options,
currencies: store?.supported_currencies?.map((c) => c.currency_code) || [],
currencies: currencyCodes,
regions,
pricePreferences,
})
Expand Down
Loading