Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): error message when isQueryable is possibly not enabled. #8096

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(utils): error message when isQueryable is possibly not enabled. #8096

merged 1 commit into from
Jul 11, 2024

Conversation

shahednasser
Copy link
Member

Improve the error message when a link is defined on a module that possibly doesn't have isQueryable enabled.

@shahednasser shahednasser requested a review from a team as a code owner July 11, 2024 16:22
@vercel Vercel
Copy link

vercel bot commented Jul 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 4:23pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 4:23pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 4:23pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 4:23pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 4:23pm
medusa-docs ⬜️ Ignored (Inspect) Jul 11, 2024 4:23pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 4:23pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: c371a85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@olivermrbl olivermrbl merged commit 85c15db into develop Jul 11, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/link-error-message branch July 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahednasser @carlos-r-l-rodrigues @olivermrbl