Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tax inclusivity management to currenices #8112

Merged
merged 1 commit into from
Jul 14, 2024
Merged

feat: Add tax inclusivity management to currenices #8112

merged 1 commit into from
Jul 14, 2024

Conversation

sradevski
Copy link
Member

@sradevski sradevski commented Jul 12, 2024 •
edited
Loading

CLOSES FRMW-2530

This is the last piece of the tax inclusivity work.

@sradevski sradevski requested a review from a team as a code owner July 12, 2024 16:32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 92040a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 7:27pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 12, 2024 7:27pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 7:27pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 7:27pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 7:27pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 7:27pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 7:27pm

@sradevski sradevski force-pushed the feat/add-tax-inclusivity-store branch from 750adae to e2657ff Compare July 12, 2024 16:44
@sradevski sradevski requested a review from a team as a code owner July 12, 2024 16:44
carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carlos-r-l-rodrigues
carlos-r-l-rodrigues reviewed Jul 12, 2024
View reviewed changes
packages/modules/pricing/src/services/pricing-module.ts
const preferences = await this.pricePreferenceService_.create(
data.map((d) => ({
...d,
is_tax_inclusive: d.is_tax_inclusive ?? false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason why we need this default value here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone passes null mikroORM throws instead of using the default value, so we need to normalize it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting 👍🏻

olivermrbl
olivermrbl approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sradevski sradevski force-pushed the feat/add-tax-inclusivity-store branch from e2657ff to 92040a9 Compare July 12, 2024 19:25
@olivermrbl olivermrbl merged commit 874d511 into develop Jul 14, 2024
23 checks passed
@olivermrbl olivermrbl deleted the feat/add-tax-inclusivity-store branch July 14, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sradevski @carlos-r-l-rodrigues @olivermrbl