Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defineMikroOrmCliConfig helper to provide default db credentials #8131

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

thetutlage
Copy link
Contributor

Fixes: #8130

In certain environments not providing explicit user credentials for the PostgresSQL results in SASL: SCRAM-SERVER-FIRST error.

This PR is an attempt to fix the same issue.

PS: I cannot reproduce it on local. But faced the same issue earlier on CI

@thetutlage thetutlage requested a review from a team as a code owner July 15, 2024 09:50
Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 10:06am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 15, 2024 10:06am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06am

Copy link

changeset-bot bot commented Jul 15, 2024

⚠️ No Changeset found

Latest commit: 4c41299

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thetutlage thetutlage requested review from adrien2p and removed request for fPolic July 15, 2024 09:51
@thetutlage thetutlage changed the title fix(defineMikroOrmCliConfig): provide default db credentials fix: defineMikroOrmCliConfig helper to provide default db credentials Jul 15, 2024
@thetutlage thetutlage merged commit 5bb8709 into develop Jul 15, 2024
23 checks passed
@thetutlage thetutlage deleted the fix/issue-8130 branch July 15, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants