Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows,medusa,order): remove return shipping #8137

Merged
merged 5 commits into from
Jul 16, 2024
Merged

feat(core-flows,medusa,order): remove return shipping #8137

merged 5 commits into from
Jul 16, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues commented Jul 15, 2024 •
edited
Loading

What:

  • DELETE /admin/returs/:id/shipping_methods/:action_id

FIXES: CC-187

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner July 15, 2024 21:22
@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 10:17am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 16, 2024 10:17am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 10:17am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 10:17am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 10:17am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 10:17am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 10:17am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ceb8fe0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few questions 👍

packages/modules/order/src/services/order-module-service.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/admin/returns/[id]/shipping-method/[action_id]/route.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/order/workflows/remove-return-shipping-method.ts Show resolved Hide resolved
integration-tests/http/__tests__/returns/returns.spec.ts Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 7123f9f into develop Jul 16, 2024
21 of 23 checks passed
@kodiakhq kodiakhq bot deleted the feat/remove-return-shipping branch July 16, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlos-r-l-rodrigues @olivermrbl