You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, just had time to review it now. It looks very good to me, just one thing, can we now omit or make optional the container to be provided when calling the run from the workflow engine public api?
Cc @shahednasser we are not obliged anymore to provide the container when using the workflow engine, which is a first step to later not have to pass the container to workflow either (still need some work such as using the workflow engine if provided to run the workflows under the hood)
@adrien2p got it, I think once we have the second step (not having to pass the container to a workflow) we can update the docs to just be helloWorkflow.run rather than helloWorkflow(container).run
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sradevski
force-pushed
the
fix/pass-shared-container-workflows
branch
from
REF FRMW-2595