Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: product module joiner config #8170

Merged
merged 5 commits into from
Jul 18, 2024
Merged

fix: product module joiner config #8170

merged 5 commits into from
Jul 18, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Jul 17, 2024 •
edited
Loading

what
Fix product module joiner config missing suffix

FIXES FRMW-2600

@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 7:46am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 18, 2024 7:46am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 7:46am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 7:46am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 7:46am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 7:46am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 7:46am

@adrien2p adrien2p marked this pull request as ready for review July 17, 2024 15:54
@adrien2p adrien2p requested a review from a team as a code owner July 17, 2024 15:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f201e0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p
Copy link
Member Author

/snapshot-this

@adrien2p
Copy link
Member Author

Not to be merged, the method suffix is computed under the hood automatically. Ill rework this pr to provide the true fox

@adrien2p
Copy link
Member Author

adrien2p commented Jul 18, 2024 •
edited
Loading

@shahednasser you can test the next snapshot 👍
Just to let you know, the field alias being used for the remote query is the snake case version of the entity name (singular/plural depending on isList). Meaning that in your scenario, you want to add the following field: product_variant.*. don't know if that part is documented

@shahednasser
Copy link
Member

@adrien2p I tried that but got an error that product_variant property doesn't exist. Would this be fixed with this change?

@adrien2p
Copy link
Member Author

@adrien2p I tried that but got an error that product_variant property doesn't exist. Would this be fixed with this change?

yes it will 👍 keep me in touch, lets generate a snap

@adrien2p
Copy link
Member Author

/snapshot-this

@github-actions GitHub Actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 76173af

shahednasser
shahednasser approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM issue fixed 🎉

@adrien2p adrien2p merged commit 398e39d into develop Jul 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@shahednasser shahednasser shahednasser approved these changes

@sradevski sradevski sradevski approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrien2p @shahednasser @sradevski @olivermrbl