Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Fix inferrence of public method name and service registration name based on configuration #8237

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

adrien2p
Copy link
Member

What
Properly infer method name and service registration name for auto generated methods of the medusa service and their impl

FIXES TRI-59

@adrien2p adrien2p marked this pull request as ready for review July 23, 2024 11:45
@adrien2p adrien2p requested a review from a team as a code owner July 23, 2024 11:45
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:09am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 23, 2024 0:09am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 0:09am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 0:09am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 0:09am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 0:09am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 0:09am

Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: b1b1a23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p
Copy link
Member Author

/snapshot-this

@olivermrbl olivermrbl merged commit a9abf44 into develop Jul 23, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/distinction-between-method-and-model-name branch July 23, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants