Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add basic support for importing products #8266

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat: Add basic support for importing products #8266

merged 1 commit into from
Jul 25, 2024

Conversation

sradevski
Copy link
Member

@sradevski sradevski commented Jul 24, 2024 •
edited
Loading

We are still missing variant pricing updates support, and async confirmation endpoint and step, but there are separate tickets for those.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e48a048

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 8:04am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 25, 2024 8:04am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:04am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:04am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:04am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:04am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 8:04am

@sradevski sradevski force-pushed the feat/add-basic-product-import branch from b51c1b5 to e48a048 Compare July 25, 2024 08:03
@sradevski sradevski marked this pull request as ready for review July 25, 2024 08:03
@sradevski sradevski requested a review from a team as a code owner July 25, 2024 08:03
olivermrbl
olivermrbl approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, nice work. Looking forward to start testing this. Think it will be easier for detecting potentials bugs and/or shortcomings of the import 👍

@sradevski sradevski merged commit 444a244 into develop Jul 25, 2024
23 checks passed
@sradevski sradevski deleted the feat/add-basic-product-import branch July 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sradevski @olivermrbl