Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart API should also return billing_address.province by default #8293

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

josetr
Copy link
Contributor

@josetr josetr commented Jul 26, 2024

Shouldn't we also return shipping_address.company / billing_address.company by default?

@josetr josetr requested a review from a team as a code owner July 26, 2024 08:43
@josetr josetr requested review from riqwan, fPolic and olivermrbl July 26, 2024 08:43
Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 66d961b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 26, 2024

@josetr is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I think the default fields will get revised as we get closer to the public v2 release, but yes, company can also be included.

@josetr
Copy link
Contributor Author

josetr commented Jul 26, 2024

I've added the company fields. I hope you don't mind.

By the way, is there any info regarding adding back the ability to update draft orders?

https://github.com/medusajs/medusa/blob/develop/packages/medusa/src/api/admin/draft-orders/%5Bid%5D/route.ts

I've been trying to wait patiently, tho I don't know how important it is for you guys right now...

@sradevski sradevski merged commit 74d0d16 into medusajs:develop Jul 26, 2024
15 of 22 checks passed
@sradevski
Copy link
Member

@josetr we are actively working on orders, currently on exchanges, claims and returns. We'll be adding missing functionalities in the next few weeks hopefully

@josetr
Copy link
Contributor Author

josetr commented Jul 26, 2024

Alright, thanks for the info and merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants