Chore/order claims 2 #8312
Chore/order claims 2 #8312
Conversation
carlos-r-l-rodrigues
requested review from
sradevski,
fPolic and
kasperkristensen
and removed request for
a team
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
carlos-r-l-rodrigues
changed the base branch from
chore/link-return-fulfillment
to
develop
| ModuleRegistrationName.ORDER | ||
| ) | ||
|
|
||
| const claimItems = input.changes.map((item) => { |
There was a problem hiding this comment.
question: Should we put this in a transformer in the workflow?
| } | ||
| ) | ||
|
|
||
| function prepareFulfillmentData({ |
There was a problem hiding this comment.
thought: Think this is 1:1 with the other prepareFulfillmentData – if so, we could extract to a utility
| for (const action of modifiedShippingMethod_.actions) { | ||
| if ( | ||
| action.action === ChangeActionType.SHIPPING_ADD && | ||
| action.return_id === orderReturn.id | ||
| ) { | ||
| returnShippingMethod = shippingMethod | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
question: If there is only one, we can just use .find() on the actions. Think that's a bit cleaner no?
| @@ -10,6 +10,7 @@ import { | |||
| AuthenticatedMedusaRequest, | |||
There was a problem hiding this comment.
question: Shouldn't we return the claim as well in all the /claims Rest APIs? It seems we are doing it in some but not all.
|
@olivermrbl , I'm addressing you comments and a few more issues in the next PR in a few minutes. |
What:
Missing: