Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard,icons,types,js-sdk): add providers to location UI #8328

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jul 29, 2024

what:

  • UI to add providers to location once the option has been created

bug found:

There is a weird overlapping back button when the modal comes up. Can be seen in the video.

providers.mp4

RESOLVES CC-231

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 1:08pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 1:08pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 1:08pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 1:08pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 1:08pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 1:08pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 1:08pm

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: e5452d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Comment on lines 195 to 197
await queryClient.invalidateQueries({
queryKey: stockLocationsQueryKeys.lists(),
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: think we can skip invalidating the lists key for this one

<HandTruck className="text-ui-fg-subtle" />
</IconAvatar>

<ListSummary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should the "+1 more" be displayed inline without spacing in between and right alignment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment below that changes this whole thing.

return (
<RouteFocusModal.Form form={form}>
<div className="flex h-full flex-col overflow-hidden">
<RouteFocusModal.Header>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: believe we started moving header actions to footer. Iinstead this use <RouteFocusModal.Footer> after <RouteFocusModal.Body>.

@riqwan
Copy link
Contributor Author

riqwan commented Jul 29, 2024

@fPolic just checked the designs again, it should've been a list. I've changed to that.

Screenshot 2024-07-29 at 18 02 02

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work. Will let @fPolic have a last look at it 👍

Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit c976361 into develop Jul 30, 2024
23 checks passed
@olivermrbl olivermrbl deleted the feat/fulfillment-providers-ui branch July 30, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants