- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard,icons,types,js-sdk): add providers to location UI #8328
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
await queryClient.invalidateQueries({ | ||
queryKey: stockLocationsQueryKeys.lists(), | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: think we can skip invalidating the lists key for this one
<HandTruck className="text-ui-fg-subtle" /> | ||
</IconAvatar> | ||
|
||
<ListSummary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: should the "+1 more" be displayed inline without spacing in between and right alignment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment below that changes this whole thing.
return ( | ||
<RouteFocusModal.Form form={form}> | ||
<div className="flex h-full flex-col overflow-hidden"> | ||
<RouteFocusModal.Header> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: believe we started moving header actions to footer. Iinstead this use <RouteFocusModal.Footer>
after <RouteFocusModal.Body>
.
@fPolic just checked the designs again, it should've been a list. I've changed to that. ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work. Will let @fPolic have a last look at it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
what:
bug found:
There is a weird overlapping back button when the modal comes up. Can be seen in the video.
providers.mp4
RESOLVES CC-231