Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows,utils,medusa): fix bug where payment collection across orders were getting updated #8401

Merged
merged 7 commits into from
Aug 2, 2024
Merged

fix(core-flows,utils,medusa): fix bug where payment collection across orders were getting updated #8401

merged 7 commits into from
Aug 2, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Aug 2, 2024 •
edited
Loading

This took embarrassingly long to debug. :|

what:

  • fixes a bug where the payment collection of other orders were getting updated
  • adds order status to payments section
Screenshot 2024-08-02 at 08 37 38 Screenshot 2024-08-02 at 08 37 48

@vercel Vercel
Copy link

vercel bot commented Aug 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 8:25am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 2, 2024 8:25am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 8:25am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 8:25am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 8:25am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 8:25am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 8:25am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c0c1436

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review August 2, 2024 03:19
@riqwan riqwan requested a review from a team as a code owner August 2, 2024 03:19
olivermrbl
olivermrbl approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

sradevski
sradevski approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments

integration-tests/http/__tests__/fixtures/order.ts Outdated Show resolved Hide resolved
integration-tests/http/__tests__/payment/admin/payment.spec.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit ce8c908 into develop Aug 2, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/order branch August 2, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski sradevski approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @sradevski @olivermrbl