feature: introduce additional_data to the product endpoints #8405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
|
thetutlage
changed the title
carlos-r-l-rodrigues
approved these changes
Aug 2, 2024
Co-authored-by: Oli Juhl <[email protected]>
riqwan
pushed a commit
that referenced
this pull request
Aug 6, 2024
riqwan
added a commit
that referenced
this pull request
Aug 6, 2024
…8436) * feat(core-flows,payment,medusa,types): add ability to set and manage refund reasons * fix(payment): validate total amount when refunding payment (#8437) Co-authored-by: Carlos R. L. Rodrigues <[email protected]> * feature: introduce additional_data to the product endpoints (#8405) * chore(docs): Generated References (#8440) Generated the following references: - `product` * chore: align payment database schema * Update packages/core/core-flows/src/payment-collection/steps/create-refund-reasons.ts Co-authored-by: Oli Juhl <[email protected]> * chore: address review --------- Co-authored-by: Carlos R. L. Rodrigues <[email protected]> Co-authored-by: Harminder Virk <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Oli Juhl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: FRMW-2647, FRMW-2648
First approach of introducing and consuming additional data.
AdminCreateProductto now includeadditional_dataas part of the payload.additional_dataas an arbitrary object. But then also, use merge the user-defined validator (if exists). This change might impact some other parts of the codebase.additional_dataand rest of the properties and pass them to the workflow as needed.