Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-medusa-app, medusa): check Node.js version before installation. #8452

Merged
merged 2 commits into from
Aug 6, 2024
Merged

feat(create-medusa-app, medusa): check Node.js version before installation. #8452

merged 2 commits into from
Aug 6, 2024

Conversation

shahednasser
Copy link
Member

Check before installation with create-medusa-app and medusa new whether the current node version is >= 20. If not, exit with an error.

@shahednasser shahednasser requested a review from a team as a code owner August 5, 2024 13:04
@vercel Vercel
Copy link

vercel bot commented Aug 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 7:04am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 6, 2024 7:04am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:04am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:04am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:04am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:04am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:04am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7f13166

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

riqwan
riqwan approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

packages/cli/create-medusa-app/src/commands/create.ts Show resolved Hide resolved
olivermrbl
olivermrbl approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @riqwan's comment, LGTM :)

@kodiakhq kodiakhq bot merged commit 98f42e8 into develop Aug 6, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/cma-node-v branch August 6, 2024 07:15
@sradevski sradevski mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahednasser @riqwan @olivermrbl