Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create return reason #8516

Merged
merged 4 commits into from
Aug 12, 2024
Merged

feat: create return reason #8516

merged 4 commits into from
Aug 12, 2024

Conversation

christiananese
Copy link
Contributor

Closes CC-305

@christiananese christiananese self-assigned this Aug 8, 2024
@christiananese christiananese requested a review from a team as a code owner August 8, 2024 14:47
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c9e2f0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 10:07am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 10:07am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 10:07am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 10:07am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 10:07am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 10:07am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 10:07am

christiananese
christiananese commented Aug 8, 2024
View reviewed changes
...ges/admin-next/dashboard/src/components/table/data-table/data-table-root/data-table-root.tsx
@@ -52,6 +52,10 @@ export interface DataTableRootProps<TData> {
* Whether the table is empty due to no results from the active query
*/
noResults?: boolean
/**
* Whether to display the tables header
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not a big fan of "negative" naming for props, but wanted to stay consistent with other props in this component

@olivermrbl
Copy link
Contributor

We might want to have a max-width on the column and truncate the text – wdyt?

CleanShot 2024-08-08 at 21 12 37@2x

@olivermrbl
Copy link
Contributor

olivermrbl commented Aug 8, 2024 •
edited
Loading

We also need to increase the padding of the content in the row to follow the design:
CleanShot 2024-08-08 at 21 15 59@2x

@olivermrbl
Copy link
Contributor

olivermrbl commented Aug 8, 2024 •
edited
Loading

We're missing a subtitle on the table:

Currently:
CleanShot 2024-08-08 at 21 19 30@2x

Design:
CleanShot 2024-08-08 at 21 20 03@2x

@christiananese christiananese marked this pull request as draft August 9, 2024 06:19
@christiananese christiananese force-pushed the feat/create-return-reason branch from ddb8952 to 0eea0ec Compare August 9, 2024 09:00
@christiananese christiananese marked this pull request as ready for review August 9, 2024 09:02
@christiananese christiananese requested a review from a team as a code owner August 9, 2024 09:02
olivermrbl
olivermrbl approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

packages/admin-next/dashboard/src/providers/keybind-provider/hooks.tsx
@@ -264,6 +264,14 @@ export const useGlobalShortcuts = () => {
type: "settingShortcut",
to: "/settings/locations",
},
{
keys: {
Mac: ["G", ",", "M"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Would this be more fitting? Typically, the keyboard shortcut is coupled with the resource name

Suggested change
Mac: ["G", ",", "M"],
Mac: ["G", ",", "R"],

@christiananese christiananese merged commit 4eb2e83 into develop Aug 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees

@christiananese christiananese

Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christiananese @olivermrbl