Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payment): Partial refunds #8603

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix(payment): Partial refunds #8603

merged 2 commits into from
Aug 15, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Aug 15, 2024

What

  • Pass refund amount to payment provider instead of full payment amount

Why

  • Without it, payments would always be fully refunded regardless of the amount specified

Closes CC-336

@olivermrbl olivermrbl requested a review from a team as a code owner August 15, 2024 09:08
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 9:08am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 15, 2024 9:08am
api-reference-v2 ⬜️ Ignored (Inspect) Aug 15, 2024 9:08am
docs-ui ⬜️ Ignored (Inspect) Aug 15, 2024 9:08am
docs-v2 ⬜️ Ignored (Inspect) Aug 15, 2024 9:08am
medusa-docs ⬜️ Ignored (Inspect) Aug 15, 2024 9:08am
resources-docs ⬜️ Ignored (Inspect) Aug 15, 2024 9:08am

Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: f1247a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! How did you come across this? 😄

@olivermrbl
Copy link
Contributor Author

olivermrbl commented Aug 15, 2024

nice! How did you come across this? 😄

Currently setting up an end-to-end store with 3rd party providers installed and noticed this happened with Stripe payments

@olivermrbl olivermrbl merged commit 9de9b38 into develop Aug 15, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/partial-refunds-pp branch August 15, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants