You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚠️ Note
In case of too many connection issue, the first thing to check (especially when running many processes) is the pool configuration in medusa-config.ts. e.g:
projectConfig: {databaseDriverOptions: {pool: {max: 8,// This number can also vary depending on the max connection configuration of your db or bouncer or whatever tech you are using and configuring},},}
Convention
With the current approach to load providers, we need to validate the convention being the following one:
module options must has the providers keys as the option being an array and must contain
resolve
id (optional) only used if the provider does not have an identifier (@carlos-r-l-rodrigues wdyt of that, seems we need to validate something here)
the provider can have an identifier static property that would be used to register the provider into the module container under __providers__${identifier | id}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carlos-r-l-rodrigues
requested review from
sradevski,
adrien2p and
olivermrbl
What:
New util added to export a provider:
ModuleProviderModule providers are registered on the Module's container using the name
__providers__+provider_key_name. It is available on Module's loaders.Postgres: #9545
In case of
too many connectionissue, the first thing to check (especially when running many processes) is thepoolconfiguration inmedusa-config.ts. e.g:Convention
With the current approach to load providers, we need to validate the convention being the following one:
providerskeys as the option being an array and must containresolveid(optional) only used if the provider does not have an identifier (@carlos-r-l-rodrigues wdyt of that, seems we need to validate something here)identifierstatic property that would be used to register the provider into the module container under__providers__${identifier | id}