🆙 update node16 -> 20 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@medyagh - you the right person to tag for a workflow approval and review? |
|
Hi @nilwurtz, thanks for the PR! One request, would you mind adding the following to That way we'll be testing with the same version, the GitHub Action Runner has Node 18 installed by default. |
|
@spowelljr Thank you for pointing that out. I hadn't noticed it. I have now pushed. |
spowelljr
requested changes
Feb 15, 2024
Co-authored-by: Steven Powell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've confirmed that npm run all passes successfully, which looks good to me. Additionally, I've noticed that @types/node is already updated to the 20.x series.
This PR is related to issue #382.