Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Mem 1331 page user stories #15

Merged
merged 39 commits into from
Dec 14, 2020
Merged

Mem 1331 page user stories #15

merged 39 commits into from
Dec 14, 2020

Conversation

KenzoBenzo
Copy link
Contributor

No description provided.

@KenzoBenzo KenzoBenzo self-assigned this Dec 4, 2020
@linear
Copy link

linear bot commented Dec 4, 2020

MEM-1331 page: User stories

When a recording or test case is clicked, the modals in this prototype will pop up https://beta.framer.com/share/Explorations--hnxrMw0TrtlrfVJsz79j/dmJhV8_cx. If test cases, the 'Expected' and 'reject' buttons wont exist.

@vercel
Copy link

vercel bot commented Dec 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/meeshkanml/webapp/es2s684r7
✅ Preview: https://webapp-git-mem-1331-page-user-stories.meeshkanml.vercel.app

Co-Authored-By: Nikolaos Kamarinakis <[email protected]>
Copy link
Contributor

@k4m4 k4m4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @KenzoBenzo! A lot of great work in this PR! I have made a few suggestions above - of course, they're only suggestions, some of which might be somewhat opinionated (all to say that you're free to ignore them).
Also, here are a few more general issues/recommendations:

  • The pagination loading bar appears in the wrong position when the user has scrolled down: loom.com/share/aa92291dda404c19bd345ae8eb9c759d.
  • Sometimes the 'records to show' count glitches and shows the wrong value (for instance, here it says 40, but there are in fact only 5 user stories being shown):

Screen Shot 2020-12-13 at 23 29 52

  • The Getting started page becomes vertically scrollable once the 'records to show' count is greater than 10 (for my screen size - viewport 1308px × 691px and screen size: 1440px × 900px): Screen Shot 2020-12-13 at 23 29 04

  • There is no scroll bar on the paginated table.

  • The "recordings" to "test cases" tab animation glitches out (I believe when the 'records to show' count is greater than 10): loom.com/share/ed63fb3eb28d4572ad1abc904e73b8a6 (note that when I was repeatedly clicking on "Recordings" in the video, at the point where I'm hovering over the button).

  • Perhaps it makes sense to make the table's column titles position static, so that they don't get hidden on scroll.

apps/webapp/components/molecules/nav-button.tsx Outdated Show resolved Hide resolved
apps/webapp/components/molecules/nav-button.tsx Outdated Show resolved Hide resolved
apps/webapp/components/molecules/nav-button.tsx Outdated Show resolved Hide resolved
apps/webapp/components/molecules/prompt-dialog.tsx Outdated Show resolved Hide resolved
apps/webapp/components/molecules/prompt-dialog.tsx Outdated Show resolved Hide resolved
apps/webapp/components/molecules/segmented-control.tsx Outdated Show resolved Hide resolved
apps/webapp/pages/user-stories.tsx Outdated Show resolved Hide resolved
apps/webapp/components/organisms/table.tsx Show resolved Hide resolved
apps/webapp/components/organisms/table.tsx Outdated Show resolved Hide resolved
@KenzoBenzo KenzoBenzo merged commit 8c4ee24 into staging Dec 14, 2020
@KenzoBenzo KenzoBenzo deleted the mem-1331-page-user-stories branch December 14, 2020 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants