-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
MEM-1331 page: User stories
When a recording or test case is clicked, the modals in this prototype will pop up https://beta.framer.com/share/Explorations--hnxrMw0TrtlrfVJsz79j/dmJhV8_cx. If test cases, the 'Expected' and 'reject' buttons wont exist. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/meeshkanml/webapp/es2s684r7 |
Co-Authored-By: Nikolaos Kamarinakis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @KenzoBenzo! A lot of great work in this PR! I have made a few suggestions above - of course, they're only suggestions, some of which might be somewhat opinionated (all to say that you're free to ignore them).
Also, here are a few more general issues/recommendations:
- The pagination loading bar appears in the wrong position when the user has scrolled down: loom.com/share/aa92291dda404c19bd345ae8eb9c759d.
- Sometimes the 'records to show' count glitches and shows the wrong value (for instance, here it says
40
, but there are in fact only5
user stories being shown):
-
The Getting started page becomes vertically scrollable once the 'records to show' count is greater than
10
(for my screen size - viewport1308px × 691px
and screen size:1440px × 900px
): -
There is no scroll bar on the paginated table.
-
The "recordings" to "test cases" tab animation glitches out (I believe when the 'records to show' count is greater than
10
): loom.com/share/ed63fb3eb28d4572ad1abc904e73b8a6 (note that when I was repeatedly clicking on "Recordings" in the video, at the point where I'm hovering over the button). -
Perhaps it makes sense to make the table's column titles position static, so that they don't get hidden on scroll.
Co-Authored-By: Nikolaos Kamarinakis <[email protected]>
…kan/meeshkan into mem-1331-page-user-stories
Co-Authored-By: Nikolaos Kamarinakis <[email protected]>
…kan/meeshkan into mem-1331-page-user-stories
No description provided.