Lsolak add video orientation extension

[lejlasolak]

No description provided.

[lminiero]

Sorry for the late response, going back to the office tomorrow and I'll review.

[lejlasolak]

Sorry for the late response, going back to the office tomorrow and I'll review.

Hi, any update?

[lminiero]

I didn't have time to look at the pull request, sorry. Hopefully I'll do that later this week, or the next.

[lminiero]

This looks much better than the approach originally proposed, thanks 👍
To make this complete, though, it should address the audio-level extension too, as it's part of the structure as well and so may get "lost in translation" just like the video-orientation one. Once that part is done, I think this is fine to merge. I'll take care of applying the same fix to the NoSIP plugin as well, which would suffer from the same problem otherwise.

As a side note, please fill in the form and sign our CLA which is a prerequisite for merging.

[lminiero]

Oh, one more thing: this should based on the plugins-media branch, not transport-cc: the latter is based on the former, but it's the former that needs the fix, since that's where we refactored RTP extensions. Once this is merged in plugins-media, I'll merge the changes in transport-cc too.

Anyway, I think I can do this myself using the Edit button, so nothing you need to worry about.

[lminiero]

Thanks for the quick fixes! Looks good to me 👍
As soon as the CLA is signed, I'll merge.

[lejlasolak]

Thanks for the quick fixes! Looks good to me 👍
As soon as the CLA is signed, I'll merge.

Done

[lminiero]

Mh, looks like I can't just rebase from GitHub, since otherwise it pulls in fixes from transport-cc as well, and not just the additions you made... Can you prepare a new PR, based on plugins-media, with just the janus_sip.c changes? Thanks!

[lejlasolak]

I created pull request on plugins-media branch
#1928

[lminiero]

Thanks! Closing this one, then.