Enable / disable recording while conference is in progress #2137
Conversation
plugins/janus_videoroom.c
Outdated
| "request" : "enable_recording", | ||
| "room" : <unique numeric ID of the room>, | ||
| "secret" : "<room secret; mandatory if configured>" | ||
| "record" : <true|false, whether this publisher should be recorded or not; optional>, |
There was a problem hiding this comment.
as i see the documentation is wrong, its not optional.
|
@tgabi333 , Thanks, fixed. |
|
great extension! using "rec_dir" we can leave empty, for example, "filename" in the configure, and leave to JANUS the naming tasks, but we avoid a common DIR for all recordings (to filter by, day, conversation ID etc etc) |
|
That's a great idea, I'll find time to add this. |
Not sure why a specific publisher is addressed here, if this is supposed to be a global recording thing. |
|
@lminiero , I changed that in that last patch, you are correct. |
|
Ah sorry for missing that, I was just looking at the description, didn't have time to review the code yet 👍 |
|
@antoniotuzzi , Sorry, I think I missed part of what you were saying, I think I get it now. It doesn't make sense here to accept the filename parameter since it would have the effect of pointing all participants to the same file. So that should be removed. |
|
@wheresjames you are right, correct I confused with a single endpoint configure... :( |
|
@wheresjames any update on my notes? If you don't address them I can't merge this... |
|
@lminiero , Sorry for the delay I've been swamped. Getting on this now. |
plugins/janus_videoroom.c
Outdated
| janus_mutex_lock(&videoroom->mutex); | ||
| janus_mutex_unlock(&rooms_mutex); | ||
| /* Set recording status */ | ||
| gboolean room_prev_recording_active = recording_active ? TRUE : FALSE; |
There was a problem hiding this comment.
No need for that, recording_active is a boolean.
There was a problem hiding this comment.
You are correct, I think I copied it that way. Pushed a fix.
|
This looks good to me: I'll add the new property to property to prevent self-recording myself, after I merge 👍 |
|
Thank you sir! |
|
See the |
This PR adds a command to the video room plugin to enable / disable recording while a conference is in progress. The command is formatted as follows.