make it possible to use custom phases besides 'P' and 'S' #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megies
force-pushed
the
different_phases
branch
from
8c6e2d0 to
9c1ef6d
Compare
|
I started using this mod today. Not really had any problems with it so far, so I think it could be good to commit to Master. |
picking and saving to quakeml works, but interactions with location routines etc. will probably very likely still only use pure 'P' and 'S'..
megies
force-pushed
the
different_phases
branch
from
9c1ef6d to
e743bc6
Compare
|
Alright.. guess I think it should be safe to merge.. Let me know if you experience any problems down the road. As mentioned in the changelog, anything that goes beyond just picking and saving to QuakeML is highly experimental when setting other phases than "P" and "S. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picking and saving to quakeml works, but interactions with location
routines etc. will probably very likely still only use pure 'P' and
'S' for now..