Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid errors when encountering arrivals without time residual set #52

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

megies
Copy link
Owner

@megies megies commented Mar 27, 2017

just ignore them during plotting..

See #49, @ChrisBail let me know if this works for you..

@ChrisBail
Copy link

Won't it be better to plot them (dashed or gray) instead of totally ignoring them (just wondering)? Anyway, If you feel it's better this way then keep it that way

@megies
Copy link
Owner Author

megies commented Mar 28, 2017

Well, I think plotting them with the same time as the pick is misleading, because then you would have to assume that the residual is 0.0 (i.e. "pick fits perfectly with best hypocenter + velocity model used") when it's rather not even set (i.e. "time residual of pick is unknown").

Honestly, I don't even know what to make of an arrival with unset residual time. I'm interpreting this as 'the pick was correctly assumed to be phase XYZ as described by pick.phase_hint but location routine can't give a residual time'.

just ignore them during plotting..

also fix some if/else checks (when time residual is 0.0 as opposed to
None)
@megies megies force-pushed the ignore_stub_arrivals branch from 6af300e to 318fcc5 Compare January 15, 2018 15:25
@megies megies merged commit 2e4ad45 into master Jan 15, 2018
@megies megies deleted the ignore_stub_arrivals branch January 15, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants