Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug with custom settings #28

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Fixes bug with custom settings #28

merged 2 commits into from
Jun 10, 2020

Conversation

bidoubiwa
Copy link
Contributor

Fixes: #26

Scenarios:

  • No custom_settings: ✅
  • Good custom_settings: ✅
  • Non existing custom_settings attributes : MeiliSearch returns a 400 Bad Request
  • Bad type for custom_settings: Doc scraper returns an error
Exception: custom_settings must be a dictionary

@bidoubiwa bidoubiwa marked this pull request as ready for review June 10, 2020 10:06
@bidoubiwa bidoubiwa requested a review from curquiza June 10, 2020 10:06
@curquiza curquiza merged commit f5c6b64 into master Jun 10, 2020
@curquiza curquiza deleted the fixes_custom_settings_bug branch June 10, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot scrap documents into meilisearch
2 participants
@bidoubiwa @curquiza