Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version file path #392

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Update version file path #392

merged 2 commits into from
Jun 1, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

@alallema I saw the publish to docker hub failed. I think the version check script should point to the version file for docs-scraper and not meilisearch-python?

Related issue

Fixes #<issue_number>

What does this PR do?

  • Updates the path to the version file

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanders41 !!! I copy-paste the code I didn't check well ... ☺️

@alallema alallema merged commit e235240 into meilisearch:main Jun 1, 2023
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

@alallema alallema added the bug Something isn't working label Jun 1, 2023
@sanders41 sanders41 deleted the script branch June 5, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants