Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert actions config - issue can no longer be reproduced #179

Merged
merged 2 commits into from Oct 12, 2022
Merged

revert actions config - issue can no longer be reproduced #179

merged 2 commits into from Oct 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2022

Pull Request

Related issue

Fixes #159

What does this PR do?

  • Reverts workaround in tests.yml (sleep 30)

I cannot reproduce the original issue anymore. Successful CI run

Thank you so much for contributing to Meilisearch!

@ghost ghost changed the title revert actions config to check issue revert actions config - issue can no longer be reproduced Oct 10, 2022
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Oct 11, 2022
@bidoubiwa
Copy link
Contributor

Thanks for this PR 🙏 Could you remove the test:ci from the package.json if it is used nowhere else?

@ghost
Copy link
Author

ghost commented Oct 11, 2022

@bidoubiwa Absolutely, I didn't find any other reference in the code for that script.
Removed, PR updated, CI is still passing on my fork.

bidoubiwa
bidoubiwa approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@bidoubiwa
Copy link
Contributor

bors merge

@bidoubiwa
Copy link
Contributor

bors r-

@bidoubiwa
Copy link
Contributor

bors merge

@bidoubiwa bidoubiwa merged commit 7edf485 into meilisearch:main Oct 12, 2022
@bidoubiwa
Copy link
Contributor

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test job ran in CI is stuck on waiting for the web server to run
2 participants
@bidoubiwa @denke8