Make test more consistent with the rest, add locales type to SearchRe…

…questGET
meilisearch · Aug 21, 2024 · 238200b · 238200b
1 parent d44a2d6
commit 238200b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/types/types.ts b/src/types/types.ts
@@ -108,7 +108,7 @@ export type HybridSearch = {
   semanticRatio?: number;
 };
 
-// @TODO: Add documentation link to available locales
+// https://www.meilisearch.com/docs/reference/api/settings#localized-attributes
 export type Locale = string;
 
 export type SearchParams = Query &
@@ -156,6 +156,7 @@ export type SearchRequestGET = Pagination &
     rankingScoreThreshold?: number;
     distinct?: string;
     retrieveVectors?: boolean;
+    locales?: Locale[];
   };
 
 export type MultiSearchQuery = SearchParams & { indexUid: string };

diff --git a/tests/search.test.ts b/tests/search.test.ts
@@ -993,19 +993,18 @@ describe.each([
     ).rejects.toHaveProperty('cause.code', ErrorStatusCode.INDEX_NOT_FOUND);
   });
 
-  test(`${permission} key: Search with locales`, async () => {
-    const localIndex = (await getClient(permission)).index(index.uid);
-    const localMasterIndex = (await getClient('Master')).index(index.uid);
+  test.only(`${permission} key: Search with locales`, async () => {
+    const client = await getClient(permission);
+    const masterClient = await getClient('Master');
 
-    const updateLocalizedAttributesEnqueuedTask =
-      await localMasterIndex.updateLocalizedAttributes([
+    const { taskUid } = await masterClient
+      .index(index.uid)
+      .updateLocalizedAttributes([
         { attributePatterns: ['title', 'comment'], locales: ['fra', 'eng'] },
       ]);
-    await localMasterIndex.waitForTask(
-      updateLocalizedAttributesEnqueuedTask.taskUid,
-    );
+    await masterClient.waitForTask(taskUid);
 
-    const searchResponse = await localIndex.search('french', {
+    const searchResponse = await client.index(index.uid).search('french', {
       locales: ['fra', 'eng'],
     });