Remove null from rankingScoreThreshold

meilisearch · Jun 11, 2024 · 2fe0b2f · 2fe0b2f
1 parent 490bf71
commit 2fe0b2f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/src/Contracts/SearchQuery.php b/src/Contracts/SearchQuery.php
@@ -238,7 +238,7 @@ public function toArray(): array
             'attributesToSearchOn' => $this->attributesToSearchOn,
             'showRankingScore' => $this->showRankingScore,
             'showRankingScoreDetails' => $this->showRankingScoreDetails,
-            'rankingScoreThreshold' => $this->rankingScoreThreshold ?? null,
+            'rankingScoreThreshold' => $this->rankingScoreThreshold,
         ], function ($item) { return null !== $item; });
     }
 }
diff --git a/src/Contracts/SimilarDocumentsQuery.php b/src/Contracts/SimilarDocumentsQuery.php
@@ -6,7 +6,7 @@
 
 class SimilarDocumentsQuery
 {
-    private int|string $id;
+    private $id;
     private ?int $offset = null;
     private ?int $limit = null;
     private ?string $embedder = null;
@@ -15,11 +15,12 @@ class SimilarDocumentsQuery
     private ?bool $showRankingScoreDetails = null;
     private ?array $filter = null;
 
-    public function setId(string|int $id): SimilarDocumentsQuery
+    /**
+     * @param int|string $id
+     */
+    public function __construct($id)
     {
         $this->id = $id;
-
-        return $this;
     }
 
     public function setOffset(?int $offset): SimilarDocumentsQuery

diff --git a/tests/Endpoints/SimilarDocumentsTest.php b/tests/Endpoints/SimilarDocumentsTest.php
@@ -30,10 +30,7 @@ public function testBasicSearchWithSimilarDocuments(): void
         self::assertSame(1, $response->getHitsCount());
 
         $documentId = $response->getHit(0)['id'];
-        $response = $this->index->searchSimilarDocuments(
-            (new SimilarDocumentsQuery())
-                ->setId($documentId)
-        );
+        $response = $this->index->searchSimilarDocuments(new SimilarDocumentsQuery($documentId));
 
         self::assertGreaterThanOrEqual(4, $response->getHitsCount());
         self::assertArrayHasKey('_vectors', $response->getHit(0));