Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github actions checkout to v4 #841

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Bump github actions checkout to v4 #841

merged 2 commits into from
Sep 11, 2023

Conversation

sanders41
Copy link
Collaborator

@sanders41 sanders41 commented Sep 4, 2023

Pull Request

GitHub Actions are currently failing across multiple repositories with network issues. the checkout action is currently having issues with this, issue here, and bumping to the newly released v4 seems to be helping. This action is not the only thing that is having issues with the network problems so we could still see failures until it is resolved, but bumping to v4 is at least helping with the checkout part.

These network issues are also what keep causing #839 to fail.

Related issue

Fixes #<issue_number>

What does this PR do?

  • Bumps checkout to v4

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the skip-changelog The PR will not appear in the release changelogs label Sep 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7f4146d) 92.20% compared to head (53eb850) 92.20%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files          13       13           
  Lines         783      783           
=======================================
  Hits          722      722           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sanders41

Hope it will help!

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 11, 2023

@sanders41 sanders41 merged commit 4e5aafa into main Sep 11, 2023
@sanders41 sanders41 deleted the github-action-checkout branch September 11, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants