-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make embedders deseralize to correct type #927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tutto bene 🇮🇹
Thank you @sanders41
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Mar 11, 2024
928: Changes related to the next Meilisearch release (v1.7.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#296 This PR: - gathers the changes related to the next Meilisearch release (v1.7.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v1.7.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.7.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ 932: Update version for the next release (v0.31.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-python to a new version: "v0.31.0" --- Part of the work of #928 --- This version introduces features released on Meilisearch v1.7.0 🎉 Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. ##⚠️ Breaking changes * Related to the experimental `vectorStore` feature: `dimensions` field is now required when using OpenAI models. ## 🐛 Bug Fixes * Make embedders deseralize to correct type (#927) sanders41 ## ⚙️ Maintenance/misc * Update author (#931) `@curquiza` Co-authored-by: meili-bot <[email protected]> Co-authored-by: Paul Sanders <[email protected]> Co-authored-by: Clémentine U. - curqui <[email protected]>
meili-bors bot
added a commit
that referenced
this pull request
Mar 11, 2024
932: Update version for the next release (v0.31.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-python to a new version: "v0.31.0" --- Part of the work of #928 --- This version introduces features released on Meilisearch v1.7.0 🎉 Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. ##⚠️ Breaking changes * Related to the experimental `vectorStore` feature: `dimensions` field is now required when using OpenAI models. ## 🐛 Bug Fixes * Make embedders deseralize to correct type (#927) sanders41 ## ⚙️ Maintenance/misc * Update author (#931) `@curquiza` Co-authored-by: meili-bot <[email protected]> Co-authored-by: Clémentine U. - curqui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #926
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!