Properly constrain version of meilisearch ruby gem #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiddle-wakka (~>) operator is not meant only for minor versions, its behavior depends on how you specify the version. ~> 0.28 will grab anything >= 0.28 and < 1, while ~> 0.28.0 will grab >= 0.28.0 to < 0.29. For more information, see meilisearch#386 .
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 88.96% 88.96%
=======================================
Files 13 13
Lines 761 761
=======================================
Hits 677 677
Misses 84 84 ☔ View full report in Codecov by Sentry. |
brunoocasali
approved these changes
Jan 14, 2025
|
bors merge |
ellnix
added a commit
to ellnix/meilisearch-rails
that referenced
this pull request
Jan 14, 2025
meili-bors bot
added a commit
that referenced
this pull request
Jan 15, 2025
388: Update version for the next release (v0.14.2) r=curquiza a=ellnix Apply hotfix: #387 Co-authored-by: ellnix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twiddle-wakka (~>) operator is not meant only for minor versions, its behavior depends on how you specify the version. ~> 0.28 will grab anything >= 0.28 and < 1, while ~> 0.28.0 will grab >= 0.28.0 to < 0.29.
For more information, see #386 .
Pull Request
Related issue
Fixes #386