Allow custom group names in multi search #391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for naming the group of results differently from the name of the index being searched, therefore allowing the same index to be searched multiple times with different options.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
+ Coverage 89.13% 89.48% +0.34%
==========================================
Files 13 13
Lines 764 770 +6
==========================================
+ Hits 681 689 +8
+ Misses 83 81 -2 ☔ View full report in Codecov by Sentry. |
Federated search can follow right after multi search when it is added.
ellnix
force-pushed
the
multi_search_enhancement
branch
from
ee3715f to
3734a11
Compare
Update #each to mimmick #each_result, not #each_hit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #364
Todo:
Two more issues remain in multi search after gets completed: #362 and #389