Skip to content

Commit

Permalink
Fix linter problems
Browse files Browse the repository at this point in the history
  • Loading branch information
ellnix committed Oct 12, 2023
1 parent 7a39c9c commit ca0c470
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 14 deletions.
16 changes: 5 additions & 11 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,27 +1,21 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-10-12 11:41:16 UTC using RuboCop version 1.50.2.
# on 2023-10-12 14:59:44 UTC using RuboCop version 1.50.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Layout/EmptyLines:
Exclude:
- 'spec/meilisearch/models/task_spec.rb'

# Offense count: 61
# Offense count: 60
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
# AllowedMethods: refine
Metrics/BlockLength:
Max: 671
Max: 559

# Offense count: 3
# Offense count: 4
# Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength:
Max: 387
Max: 410

# Offense count: 1
# Configuration parameters: Max, CountKeywordArgs.
Expand Down
4 changes: 3 additions & 1 deletion spec/meilisearch/client/indexes_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@

it 'warns about deprecation' do
client.create_index!('books')
expect(MeiliSearch::Utils).to have_received(:soft_deprecate).with('Client#create_index!', a_string_matching(/books/))
expect(MeiliSearch::Utils)
.to have_received(:soft_deprecate)
.with('Client#create_index!', a_string_including('books'))
end
end

Expand Down
2 changes: 0 additions & 2 deletions spec/meilisearch/index/settings_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
synonyms: { wow: ['world of warcraft'] }
).await


task = index.reset_settings
expect(task.type).to eq('settingsUpdate')
task.await
Expand Down Expand Up @@ -539,7 +538,6 @@
expect(index.pagination).to eq(default_pagination.transform_keys(&:to_s))
end


describe '#update_pagination' do
it 'updates pagination' do
index.update_pagination(pagination).await
Expand Down

0 comments on commit ca0c470

Please sign in to comment.