-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code samples and remove useless ones #486
Conversation
index('books').update_faceting({ max_values_per_facet: 2 }) | ||
index('books').update_faceting({ | ||
max_values_per_facet: 2, | ||
sort_facet_values_by: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue open of this, can you confirm this code sample is still valid @brunoocasali?
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 9 9
Lines 508 508
=======================================
Hits 506 506
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
I created scripts to manage code samples (internal only)
However, only
search_parameter_guide_crop_marker_1
,facet_search_2
were added/fixed, because of missing feature implementation for the others