Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruby 3.0 & Upgrade codecov setup #533

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

brunoocasali
Copy link
Member

Just a couple of maintenance stuff:

  • remove ruby 3.0 from the CI runs.
  • Upload codecov only from the ruby 3.3 execution
  • Remove codecov gem
  • Add simplecov-cobertura gem

@brunoocasali brunoocasali requested review from curquiza and ellnix May 7, 2024 17:53
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza curquiza added the breaking-change The related changes are breaking for the users label May 7, 2024
@curquiza
Copy link
Member

curquiza commented May 7, 2024

Putting breaking-change, as usual when we drop a support (to let user know and not only increase the patch)

Copy link
Contributor

meili-bors bot commented May 7, 2024

@meili-bors meili-bors bot merged commit b017f49 into main May 7, 2024
6 checks passed
@meili-bors meili-bors bot deleted the codecov-improvement branch May 7, 2024 17:55
@brunoocasali
Copy link
Member Author

I don't think this is a breaking @curquiza because we will not change the gemspec. The users can still use the gem with ruby 3 s.required_ruby_version = '>= 3.0.0'

@brunoocasali
Copy link
Member Author

So, under the CI, we can keep only the supported versions from the ruby core team, but for the user side, we still support their older version. What do you think?

@ellnix
Copy link
Collaborator

ellnix commented May 7, 2024

So, under the CI, we can keep only the supported versions from the ruby core team, but for the user side, we still support their older version. What do you think?

Can we really say we maintain something if we do not run our tests using it? Would be a bad look if there are issues with our "supported" versions that can only be caught by the users.

meili-bors bot added a commit that referenced this pull request May 15, 2024
534: Clarify the ruby version r=brunoocasali a=brunoocasali

Addressing this comment: #533 (comment)

Co-authored-by: Bruno Casali <[email protected]>
meili-bors bot added a commit that referenced this pull request Jul 9, 2024
549: Update docker-compose.yml to use supported ruby version r=brunoocasali a=bb

# Pull Request

## Related issue
Related to #533

## What does this PR do?
- use Ruby 3.3 instead of 3.0 in the compose file

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Benjamin Bock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants