-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ruby 3.0 & Upgrade codecov setup #533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Putting |
I don't think this is a breaking @curquiza because we will not change the gemspec. The users can still use the gem with ruby 3 |
So, under the CI, we can keep only the supported versions from the ruby core team, but for the user side, we still support their older version. What do you think? |
Can we really say we maintain something if we do not run our tests using it? Would be a bad look if there are issues with our "supported" versions that can only be caught by the users. |
534: Clarify the ruby version r=brunoocasali a=brunoocasali Addressing this comment: #533 (comment) Co-authored-by: Bruno Casali <[email protected]>
549: Update docker-compose.yml to use supported ruby version r=brunoocasali a=bb # Pull Request ## Related issue Related to #533 ## What does this PR do? - use Ruby 3.3 instead of 3.0 in the compose file ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Benjamin Bock <[email protected]>
Just a couple of maintenance stuff:
codecov
gemsimplecov-cobertura
gem