-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for document_id to prevent nil or empty values #557
Add validation for document_id to prevent nil or empty values #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a critical issue in Meilisearch, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR
But the tests fail. Can fix them?
@Trehana the tests still don't pass 😢 |
@Trehana the tests still do not pass |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 677 684 +7
=========================================
+ Hits 677 684 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Trehana the PR looks good!
I just need you to run the rubocop command: bundle exec rubocop --autp-gen-config
and commit the changes.
After that I will be able to merge and release :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Thanks a lot for your contribution!
557: Add validation for document_id to prevent nil or empty values r=brunoocasali a=Trehana # Pull Request ## Related issue Fixes #556 ## What does this PR do? Add validation for document_id to prevent nil or empty values ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Trehana Fernando <[email protected]>
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
Pull Request
Related issue
Fixes #556
What does this PR do?
Add validation for document_id to prevent nil or empty values
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!