Make vector test compatible with Meilisearch v1.6+ #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dureuill
added
the
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 689 689
=========================================
Hits 689 689 ☔ View full report in Codecov by Sentry. |
dureuill
force-pushed
the
modernize-vector-test
branch
2 times, most recently
from
7880ede to
6dfc95f
Compare
curquiza
requested changes
Dec 3, 2024
dureuill
force-pushed
the
modernize-vector-test
branch
from
6dfc95f to
e9c6161
Compare
|
Done ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the test in
MeiliSearch::Index - Vector searchto be compatible with the Meilisearch v1.6+ way of declaring embedders and vectors.It allows
bundle exec rspecto pass against the upcoming Meilisearch v1.12.0Fixes #576