Support prefix and facet search settings #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 703 715 +12
=========================================
+ Hits 703 715 +12 ☔ View full report in Codecov by Sentry. |
ellnix
changed the title
|
Merge conflict. |
Appended "_setting" to all facet search settings to avoid collisions with the `facet_search` method and avoid confusion.
ellnix
force-pushed
the
prefix_and_facet_search
branch
from
1d2a0f1 to
6a93a5c
Compare
|
@brunoocasali rebased to deal with the conflicts |
ellnix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #580
Appended "_setting" to all facet search settings to avoid collisions
with the
facet_searchmethod and avoid confusion.