This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
Image tool now functioning with new features on Strapi V4 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary, and automatically shuts the media library window after saving.
This fixes an issue with the link and image tools not working with yarn/npm installed packages.
This feature adds in the width, height, size, mime, and the responsive image data to the image tool. It saves all of that information to the database and is returned so that the user can use that information in their frontend. This addresses several open and closed issues: - #6 - #16 - #22 (duplicate of closed 6)
jaskipper
changed the title
Strapi V4 has its own design system, and the field label wasn't showing. I'm working on moving over to @strapi/design-system. This commit shows the label.
removed requirement for @buffetJS. Refactored.
Doesn't fix issue with #5, but does allow pasting from external websites.
|
@melishev - For the most part, I believe that I am done with commits to this. Please check 6223702, as this a complete refactoring of Wysiwyg > index.js. I've removed the usage of @buffetjs. From everything that I can tell, with all of these changes, EditorJS is working perfectly in v4 with the following exceptions:
|
changed Link to LinkTool to also enable inline links. See Jungwoo-An/react-editor-js#6.
Closed
melishev
suggested changes
Mar 11, 2022
melishev
approved these changes
Mar 11, 2022
melishev
suggested changes
Mar 11, 2022
This was
linked to
issues
Mar 11, 2022
This was
linked to
issues
Mar 11, 2022
|
@melishev I believe that all changes that you requested have been completed. |
|
🎉 This PR is included in version 2.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I now have the image tool working. I've changed some code and added some comparing this code with the following tutorial: https://docs.strapi.io/developer-docs/latest/guides/registering-a-field-in-admin.html#creating-the-wysiwyg.