Got the project up and running with modern tooling #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damn `Directory.Build.props`. After at least an hour or two questioning the build system's ability to follow simple logic (path shan't change the results of identical solutions), removing line 6 fixed loads of "Metadata file not found" build errors.
|
Don't merge. The .NET Core update broke Unfortunately, you can't turn a ready PR into a draft. |
|
I removed the limit editor target framerate setting commit as I decided that this PR will not introduce new features. |
Any newer version causes "Method not found" crashes.
|
I had to downgrade to .NET Core 2.0, as any higher version would cause "Method not found" crashes. Well, it's still something and on that version I haven't found any crashes that weren't there before I touched the project. This PR is now ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Can't find src/TestProj.sln #1, closes where am solution file #3, mention Help me . How can i Build this engine from source code ?? #11, mention Loading issues #7.
Mention .net core 2 support #10 — can be compiled with .NET Core 2.2, but causes "Method not found" crashes.
(Most referred issues are closed, but haven't actually been resolved. They've been mentioned to notify the authors.)
I'd also like to ask @mellinoe why implicit framework references were disabled.