fix: Avoid duplicate entries in required array of JSON schema helpe…

…rs (#1214)

* fix: Avoid duplicate entries in `required` array of JSON schema helpers

* Update snapshots

singer_sdk/typing.py

@@ -47,7 +47,7 @@
 
 import json
 import sys
-from typing import Any, Generic, Mapping, TypeVar, Union, cast
+from typing import Any, Generic, ItemsView, Mapping, TypeVar, Union, cast
 
 import sqlalchemy
 from jsonschema import validators
@@ -544,7 +544,7 @@ def __init__(
               }
             }
         """
-        self.wrapped: list[Property] = list(properties)
+        self.wrapped: dict[str, Property] = {prop.name: prop for prop in properties}
         self.additional_properties = additional_properties
         self.pattern_properties = pattern_properties
 
@@ -557,7 +557,7 @@ def type_dict(self) -> dict:  # type: ignore  # OK: @classproperty vs @property
         """
         merged_props = {}
         required = []
-        for w in self.wrapped:
+        for w in self.wrapped.values():
             merged_props.update(w.to_dict())
             if not w.optional:
                 required.append(w.name)
@@ -604,21 +604,21 @@ def type_dict(self) -> dict:  # type: ignore  # OK: @classproperty vs @property
 class PropertiesList(ObjectType):
     """Properties list. A convenience wrapper around the ObjectType class."""
 
-    def items(self) -> list[tuple[str, Property]]:
+    def items(self) -> ItemsView[str, Property]:
         """Get wrapped properties.
 
         Returns:
             List of (name, property) tuples.
         """
-        return [(p.name, p) for p in self.wrapped]
+        return self.wrapped.items()
 
     def append(self, property: Property) -> None:
         """Append a property to the property list.
 
         Args:
             property: Property to add
         """
-        self.wrapped.append(property)
+        self.wrapped[property.name] = property
 
 
 def to_jsonschema_type(

tests/snapshots/jsonschema/required_duplicates.json

@@ -25,7 +25,6 @@
     }
   },
   "required": [
-    "email",
     "email",
     "username"
   ]

tests/snapshots/jsonschema/required_duplicates_additional_properties.json

@@ -25,7 +25,6 @@
     }
   },
   "required": [
-    "email",
     "email",
     "username"
   ],

tests/snapshots/jsonschema/required_duplicates_no_additional_properties.json

@@ -25,7 +25,6 @@
     }
   },
   "required": [
-    "email",
     "email",
     "username"
   ],