Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add standard target tests for SQL targets #1123

Closed
wants to merge 5 commits into from
Closed

feat: add standard target tests for SQL targets #1123

wants to merge 5 commits into from

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Oct 28, 2022 •
edited
Loading

@aaronsteers
Copy link
Contributor

Related PR (now slightly stale) here:

Would be great to incorporate the best of these approaches - both for taps and targets. Although admittedly that would be a lot of scope for PR.

@kgpayne kgpayne self-assigned this Nov 8, 2022
@kgpayne kgpayne mentioned this pull request Nov 11, 2022
Merged
@kgpayne kgpayne closed this Nov 11, 2022
@kgpayne
Copy link
Contributor Author

kgpayne commented Nov 11, 2022

Closed in favour of #1169

@kgpayne
Copy link
Contributor Author

kgpayne commented Jan 30, 2023

Closed by #1171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon Awaiting requested review from edgarrmondragon edgarrmondragon will be requested when the pull request is marked ready for review edgarrmondragon is a code owner

Assignees

@kgpayne kgpayne

Labels
None yet
Projects
Office Hours
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: add target tests to singer_sdk.testing
2 participants
@kgpayne @aaronsteers