-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Labeled enumerations #2875
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces the ability to add titles to JSON schema types, specifically for Entity relationship diagram showing JSON Schema type structureerDiagram
JSONSchema ||--o{ Constant : contains
Constant {
string const
string title
}
JSONSchema ||--o{ OneOf : contains
OneOf ||--|{ Constant : combines
Class diagram showing the updated JSONTypeHelper and Constant classesclassDiagram
class JSONTypeHelper {
+allowed_values: list[T]
+examples: list[T]
+nullable: bool
+title: str
+type_dict(): dict
+extras(): dict
+to_dict(): dict
}
class Constant {
+value: _JsonValue
+type_dict(): dict
}
JSONTypeHelper <|-- Constant
note for JSONTypeHelper "Added title attribute"
note for Constant "Updated to support title"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
- Coverage 91.33% 91.26% -0.07%
==========================================
Files 62 62
Lines 5203 5211 +8
Branches 675 677 +2
==========================================
+ Hits 4752 4756 +4
- Misses 319 321 +2
- Partials 132 134 +2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2875 will not alter performanceComparing Summary
|
Summary by Sourcery
New Features: