Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

should use docker volume rm #24

Closed
mfournier opened this issue May 24, 2016 · 0 comments
Closed

should use docker volume rm #24

mfournier opened this issue May 24, 2016 · 0 comments

Comments

@mfournier
Copy link
Contributor

Since docker 1.9 introduced the docker volume subcommand, removing volumes with docker-cleanup-volumes.sh only partially removes them. The data is removed, but docker volume ls still lists them.

This has the unfortunate side effect that creating named volumes with the same name as a previously removed one will blocks. Which makes containers startup stall when implicitly creating volumes with the -v switch.

mfournier pushed a commit to mfournier/docker-cleanup that referenced this issue May 24, 2016
`docker-cleanup-volumes.sh` doesn't remove volumes properly, since
docker introduced the "volume" subcommand in 1.9.0.

This patch detects the docker version, and runs either
`docker-cleanup-volumes.sh` or `docker volume rm` accordingly.

Fixes meltwater#24
mfournier pushed a commit to mfournier/community-catalog that referenced this issue May 24, 2016
The initial motivation for this version bump is support for docker 1.9+
Currently volumes don't get removed properly and lead to containers to
stall at start up, which is a pain to diagnose in rancher.

ref: meltwater/docker-cleanup#24
cloudnautique pushed a commit to rancher/community-catalog that referenced this issue Sep 22, 2016
* Janitor: new docker-cleanup image version

The initial motivation for this version bump is support for docker 1.9+
Currently volumes don't get removed properly and lead to containers to
stall at start up, which is a pain to diagnose in rancher.

ref: meltwater/docker-cleanup#24

* janitor: add support for KEEP_CONTAINERS_NAMED feature

* janitor: document '**None**' and '**All**'

* janitor: run with privileged mode unconditionnally

According to @sshipway, it seemed to be incompatible with a lot of
docker/rancher versions.

* janitor: bump docker-cleanup image version to 1.8.0
rawmind0 pushed a commit to rancher/community-catalog that referenced this issue Nov 30, 2016
* Janitor: new docker-cleanup image version

The initial motivation for this version bump is support for docker 1.9+
Currently volumes don't get removed properly and lead to containers to
stall at start up, which is a pain to diagnose in rancher.

ref: meltwater/docker-cleanup#24

* janitor: add support for KEEP_CONTAINERS_NAMED feature

* janitor: document '**None**' and '**All**'

* janitor: run with privileged mode unconditionnally

According to @sshipway, it seemed to be incompatible with a lot of
docker/rancher versions.

* janitor: bump docker-cleanup image version to 1.8.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant