Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

Only use anon credentials for public s3 buckets #187

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Conversation

cmckeen
Copy link
Contributor

@cmckeen cmckeen commented Sep 30, 2021

Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Fixes #188

Description

Add optional s3_bucket_public setting to use anonymous credentials when accessing public S3 buckets.

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

@cmckeen
Copy link
Contributor Author

cmckeen commented Oct 1, 2021

fixes #188

@cmckeen cmckeen merged commit 080c2e5 into master Oct 1, 2021
@cmckeen cmckeen deleted the ateam-11458 branch October 1, 2021 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.2.0 breaks EC2 IAM role bucket access
2 participants